Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(element): fix portal destroy #1898

Merged
merged 1 commit into from
Jul 29, 2021
Merged

fix(element): fix portal destroy #1898

merged 1 commit into from
Jul 29, 2021

Conversation

muuyao
Copy link
Collaborator

@muuyao muuyao commented Jul 29, 2021

Before submitting a pull request, please make sure the following is done...

  • Ensure the pull request title and commit message follow the Commit Specific in English.
  • Fork the repo and create your branch from master or formily_next.
  • If you've added code that should be tested, add tests!
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes (npm test).
  • Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

Please do not delete the above content


What have you changed?

fix portal destroy

@muuyao muuyao changed the title fix(element): fix protal destroy fix(element): fix portal destroy Jul 29, 2021
@codecov
Copy link

codecov bot commented Jul 29, 2021

Codecov Report

Merging #1898 (97e41fb) into formily_next (48f574e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           formily_next    #1898   +/-   ##
=============================================
  Coverage         92.70%   92.71%           
=============================================
  Files               136      136           
  Lines              6114     6121    +7     
  Branches           1520     1471   -49     
=============================================
+ Hits               5668     5675    +7     
  Misses              442      442           
  Partials              4        4           
Impacted Files Coverage Δ
packages/core/src/models/ArrayField.ts 100.00% <100.00%> (ø)
packages/core/src/models/Field.ts 99.21% <100.00%> (+<0.01%) ⬆️
packages/core/src/models/Form.ts 99.69% <100.00%> (ø)
packages/core/src/models/VoidField.ts 100.00% <100.00%> (ø)
packages/core/src/shared/internals.ts 95.77% <100.00%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52457e1...97e41fb. Read the comment docs.

@janryWang janryWang merged commit 1036440 into alibaba:formily_next Jul 29, 2021
@muuyao muuyao deleted the fix-portal-destroy branch September 28, 2021 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants