Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(json-schema): refactor stringify type to fix literal type is erased #1508

Merged
merged 1 commit into from
May 26, 2021

Conversation

liuweiGL
Copy link
Collaborator

Before submitting a pull request, please make sure the following is done...

  • Ensure the pull request title and commit message follow the Commit Specific in English.
  • Fork the repo and create your branch from master or formily_next.
  • If you've added code that should be tested, add tests!
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes (npm test).
  • Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

解决的问题

SchemaField 中的 component 跟 decorator 属性类型被 stringify 抹掉了。

修复之前的效果

image

修复之后效果

image

@codecov-commenter
Copy link

codecov-commenter commented May 25, 2021

Codecov Report

Merging #1508 (f75345c) into formily_next (4c098d2) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           formily_next    #1508      +/-   ##
================================================
- Coverage         89.50%   89.50%   -0.01%     
================================================
  Files               137      137              
  Lines              6004     6067      +63     
  Branches           1529     1550      +21     
================================================
+ Hits               5374     5430      +56     
- Misses              627      632       +5     
- Partials              3        5       +2     
Impacted Files Coverage Δ
...ckages/reactive-vue/src/observer/observerInVue2.ts 95.45% <0.00%> (-4.55%) ⬇️
packages/vue/src/components/Field.ts 95.65% <0.00%> (-4.35%) ⬇️
packages/vue/src/components/ArrayField.ts 96.00% <0.00%> (-4.00%) ⬇️
packages/vue/src/components/ObjectField.ts 96.00% <0.00%> (-4.00%) ⬇️
packages/vue/src/components/RecursionField.ts 72.00% <0.00%> (-1.12%) ⬇️
packages/validator/src/parser.ts 86.44% <0.00%> (-0.23%) ⬇️
packages/path/src/types.ts 100.00% <0.00%> (ø)
packages/core/src/shared/index.ts 100.00% <0.00%> (ø)
packages/reactive/src/reaction.ts 95.30% <0.00%> (ø)
packages/vue/src/shared/context.ts 100.00% <0.00%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c098d2...f75345c. Read the comment docs.

@janryWang janryWang merged commit 43e79a6 into alibaba:formily_next May 26, 2021
@liuweiGL liuweiGL deleted the refactor-stringify branch May 26, 2021 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants