Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix the effects of IFormProps losing generic type #1418

Merged
merged 2 commits into from
May 13, 2021

Conversation

liuweiGL
Copy link
Collaborator

Before submitting a pull request, please make sure the following is done...

  1. Fork the repo and create your branch from master.
  2. If you've added code that should be tested, add tests!
  3. If you've changed APIs, update the documentation.
  4. Ensure the test suite passes (npm test).
  5. Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

@codecov-commenter
Copy link

codecov-commenter commented May 13, 2021

Codecov Report

Merging #1418 (c53b83c) into formily_next (e79d0a3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           formily_next    #1418   +/-   ##
=============================================
  Coverage         89.77%   89.77%           
=============================================
  Files               137      137           
  Lines              5927     5927           
  Branches           1504     1504           
=============================================
  Hits               5321     5321           
  Misses              603      603           
  Partials              3        3           
Impacted Files Coverage Δ
packages/core/src/types.ts 100.00% <ø> (ø)
packages/core/src/shared/externals.ts 100.00% <100.00%> (ø)
packages/react/src/hooks/useForm.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e79d0a3...c53b83c. Read the comment docs.

@janryWang janryWang merged commit ee8d118 into alibaba:formily_next May 13, 2021
@liuweiGL liuweiGL deleted the fix-form-type branch May 19, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants