fix: getSchema returning undefined doesn't break setIn (#269)

alibaba · Aug 19, 2019 · da1f7a2 · da1f7a2
1 parent 0f7edab
commit da1f7a2
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/packages/utils/src/__tests__/index.spec.js b/packages/utils/src/__tests__/index.spec.js
@@ -31,6 +31,21 @@ test('test setIn auto create array', () => {
   ).toBeTruthy()
 })
 
+test('getSchema return undefined', () => {
+  const value = {}
+  setIn(value, 'array.0.bb.2', 'hello world', () => {})
+
+  expect(
+    isEqual(value, {
+      array: [
+        {
+          bb: [undefined, undefined, 'hello world']
+        }
+      ]
+    })
+  ).toBeTruthy()
+})
+
 test('test setIn dose not affect other items', () => {
   const value = {
     aa: [

diff --git a/packages/utils/src/accessor.ts b/packages/utils/src/accessor.ts
@@ -504,7 +504,8 @@ function _setIn(
       if (/^\d+$/.test(pathArr[i + 1 + ''])) {
         if (getSchema) {
           const schema = getSchema(pathArr.slice(0, i) as string[])
-          if (schema.type === 'array') {
+
+          if (!schema || schema.type === 'array') {
             obj[p] = []
           } else {
             obj[p] = {}