style: simplify code (#3506)

* style: simplify code * test: add test for isPathPattern
alibaba · Nov 2, 2022 · d6a894f · d6a894f
1 parent 0c96914
commit d6a894f
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 5 deletions.
diff --git a/packages/path/src/__tests__/basic.spec.ts b/packages/path/src/__tests__/basic.spec.ts
@@ -0,0 +1,12 @@
+import { Path } from '../'
+
+const { isPathPattern, match } = Path
+
+test('isPathPattern', () => {
+  expect(isPathPattern('obj')).toBeTruthy()
+  expect(isPathPattern(['obj', 'aa'])).toBeTruthy()
+  expect(isPathPattern(/^obj/)).toBeTruthy()
+
+  const matcher = match('obj.aa')
+  expect(isPathPattern(matcher)).toBeTruthy()
+})
diff --git a/packages/path/src/index.ts b/packages/path/src/index.ts
@@ -513,15 +513,12 @@ export class Path {
   }
 
   static isPathPattern(target: any): target is Pattern {
-    if (
+    return !!(
       isStr(target) ||
       isArr(target) ||
       isRegExp(target) ||
       (isFn(target) && target[isMatcher])
-    ) {
-      return true
-    }
-    return false
+    )
   }
 
   static transform<T>(