Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve reproducibility of the build #1604

Merged
merged 1 commit into from
Dec 8, 2020
Merged

Conversation

hboutemy
Copy link
Contributor

@hboutemy hboutemy commented Dec 6, 2020

as checked in Reproducible Central https://github.com/jvm-repo-rebuild/reproducible-central#com.taobao.arthas:arthas-all, reproducibility of latest releases has improved (with 3.4.4 having been done from a dirty Git workspace...) but after having checked 3.4.5, there are 2 remaining issues:

  1. there are 2 remaining non-reproducible Git properties, that this PR removes
  2. something during the rebuild changes pom.xml xsd from http to https

Changing xsd to https://maven.apache.org/xsd/maven-4.0.0.xsd in source tree could be a good idea, I don't know if there are any objections

@hengyunabc hengyunabc added this to the 3.4.6 milestone Dec 7, 2020
@hengyunabc hengyunabc merged commit 9b1065c into alibaba:master Dec 8, 2020
hengyunabc added a commit that referenced this pull request Dec 8, 2020
@hengyunabc
Copy link
Collaborator

Thank you very much, the xsd urls changed to https.

@hboutemy
Copy link
Contributor Author

FYI, I just understood what changed http to https (or vice versa): it's flatten-maven-plugin, that changes the value based on Maven version (because of https://issues.apache.org/jira/browse/MNG-6778 )

then:

  1. it's better to have https in your sources
  2. I'll update my reproduce script to use mvnw, to make sure the reproduce script uses the same Maven version than you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants