Improve arthas stop logic (#1513, #1514) #1517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hengyunabc
reviewed
Sep 22, 2020
agent/src/main/java/com/taobao/arthas/agent334/AgentBootstrap.java
Outdated
Show resolved
Hide resolved
agent/src/main/java/com/taobao/arthas/agent334/AgentBootstrap.java
Outdated
Show resolved
Hide resolved
agent/src/main/java/com/taobao/arthas/agent334/AgentBootstrap.java
Outdated
Show resolved
Hide resolved
hengyunabc
reviewed
Sep 22, 2020
agent/src/main/java/com/taobao/arthas/agent334/AgentBootstrap.java
Outdated
Show resolved
Hide resolved
| @@ -352,6 +352,9 @@ private void bind(Configure configure) throws Throwable { | |||
| } | |||
|
|
|||
| shellServer.listen(new BindHandler(isBindRef)); | |||
| if (!isBind()) { | |||
| throw new RuntimeException("some ports bind failed"); | |||
There was a problem hiding this comment.
这个异常信息不清楚。 另外，可以用 IllegalStateException
There was a problem hiding this comment.
已改为"One or more ports bind failed"，每个term server bind失败时已经有错误信息，这里不需要再带上了吧？
| } | ||
| shutdownWorkGroup(); | ||
| logger().error("Error during start as-server", e); | ||
| destroy(); |
There was a problem hiding this comment.
原来的代码有调用 shutdownWorkGroup()，新的代码没有
There was a problem hiding this comment.
原来的destroy() 方法为何没有调用shutdownWorkGroup()？ 我加上去了
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issues:
#1514
#1513