Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add volatile in double-checked lock #466

Merged
merged 1 commit into from
Jan 30, 2019

Conversation

mjaow
Copy link
Contributor

@mjaow mjaow commented Jan 27, 2019

Describe what this PR does / why we need it

add volatile in double-checked lock and fix concurrent problem

Does this pull request fix one issue?

Describe how you did it

add volatile in double-checked lock

Describe how to verify it

CI

Special notes for reviews

@codecov-io
Copy link

Codecov Report

Merging #466 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #466   +/-   ##
=========================================
  Coverage     37.66%   37.66%           
  Complexity      983      983           
=========================================
  Files           235      235           
  Lines          7429     7429           
  Branches       1017     1017           
=========================================
  Hits           2798     2798           
  Misses         4271     4271           
  Partials        360      360
Impacted Files Coverage Δ Complexity Δ
...tinel/slots/clusterbuilder/ClusterBuilderSlot.java 71.42% <100%> (ø) 8 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30907e4...4ae82cc. Read the comment docs.

@sczyh30 sczyh30 added the to-review To review label Jan 28, 2019
Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit 5c0fd56 into alibaba:master Jan 30, 2019
@sczyh30
Copy link
Member

sczyh30 commented Jan 30, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants