Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some unit test for StatisticNode, ClusterNode and DefaultNodeBuilder class #423

Merged
merged 8 commits into from
Jan 29, 2019

Conversation

cdfive
Copy link
Collaborator

@cdfive cdfive commented Jan 15, 2019

Describe what this PR does / why we need it

Add some unit test for StatisticNode, ClusterNode and DefaultNodeBuilder class

Does this pull request fix one issue?

NONE

Describe how you did it

Learning how to use and have a try.

Describe how to verify it

Run mvn test

Special notes for reviews

@sczyh30 sczyh30 added the to-review To review label Jan 15, 2019
@sczyh30
Copy link
Member

sczyh30 commented Jan 15, 2019

👍

@codecov-io
Copy link

codecov-io commented Jan 15, 2019

Codecov Report

Merging #423 into master will increase coverage by 0.6%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #423     +/-   ##
===========================================
+ Coverage      37.7%   38.31%   +0.6%     
- Complexity      981     1006     +25     
===========================================
  Files           235      235             
  Lines          7407     7407             
  Branches       1014     1014             
===========================================
+ Hits           2793     2838     +45     
+ Misses         4254     4209     -45     
  Partials        360      360
Impacted Files Coverage Δ Complexity Δ
...sp/sentinel/slots/statistic/data/MetricBucket.java 100% <0%> (+2.94%) 19% <0%> (+1%) ⬆️
...a/csp/sentinel/slots/statistic/base/LeapArray.java 69.62% <0%> (+7.59%) 25% <0%> (+3%) ⬆️
...p/sentinel/slots/statistic/metric/ArrayMetric.java 78.94% <0%> (+14.91%) 28% <0%> (+7%) ⬆️
...a/com/alibaba/csp/sentinel/node/StatisticNode.java 81.96% <0%> (+16.39%) 28% <0%> (+7%) ⬆️
...ibaba/csp/sentinel/slots/block/BlockException.java 57.69% <0%> (+19.23%) 7% <0%> (+3%) ⬆️
...ava/com/alibaba/csp/sentinel/node/ClusterNode.java 100% <0%> (+27.27%) 8% <0%> (+4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 303ae86...d5ad044. Read the comment docs.

@sczyh30 sczyh30 added the area/test Issue or PR related to test cases label Jan 28, 2019
Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit 22e8d85 into alibaba:master Jan 29, 2019
@sczyh30
Copy link
Member

sczyh30 commented Jan 29, 2019

Cool, thanks for contributing! 👍

@sczyh30 sczyh30 removed the to-review To review label Jan 29, 2019
CST11021 pushed a commit to CST11021/Sentinel that referenced this pull request Nov 3, 2021
… the store (alibaba#423)

* Fixed issue alibaba#411

* fix cast in getAllDelayOffset

* Update AdminBrokerProcessor.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test Issue or PR related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants