-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some unit test for StatisticNode, ClusterNode and DefaultNodeBuilder class #423
Conversation
👍 |
Codecov Report
@@ Coverage Diff @@
## master #423 +/- ##
===========================================
+ Coverage 37.7% 38.31% +0.6%
- Complexity 981 1006 +25
===========================================
Files 235 235
Lines 7407 7407
Branches 1014 1014
===========================================
+ Hits 2793 2838 +45
+ Misses 4254 4209 -45
Partials 360 360
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Cool, thanks for contributing! 👍 |
… the store (alibaba#423) * Fixed issue alibaba#411 * fix cast in getAllDelayOffset * Update AdminBrokerProcessor.java
Describe what this PR does / why we need it
Add some unit test for
StatisticNode
,ClusterNode
andDefaultNodeBuilder
classDoes this pull request fix one issue?
NONE
Describe how you did it
Learning how to use and have a try.
Describe how to verify it
Run mvn test
Special notes for reviews