Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sentinel can feel exception though application has configured E… #3409

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

24kpure
Copy link
Contributor

@24kpure 24kpure commented May 29, 2024

Describe what this PR does / why we need it
sentinel can feel exception though application has configured ExceptionHandler

Does this pull request fix one issue?
#3141
#3149

Describe how you did it
Add a class SentinelExceptionAware which implement HandlerExceptionResolver and put exception into request.

Describe how to verify it
UT & add it in my project

Special notes for reviews
Thanks for your work.

@24kpure
Copy link
Contributor Author

24kpure commented May 29, 2024

@sczyh30 @jasonjoo2010 @brotherlu-xcq @LearningGp
I have raised mr(#3149) for a year so that sentinel default branch changed to 1.8.
Maybe reviewer can be faster this time,thanks~

Copy link

codecov bot commented May 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.

Project coverage is 45.85%. Comparing base (bb813dd) to head (5c2ba70).
Report is 6 commits behind head on 1.8.

Files Patch % Lines
...ter/spring/webmvc/AbstractSentinelInterceptor.java 0.00% 15 Missing ⚠️
.../adapter/spring/webmvc/SentinelExceptionAware.java 0.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                1.8    #3409      +/-   ##
============================================
- Coverage     45.90%   45.85%   -0.06%     
+ Complexity     2147     2146       -1     
============================================
  Files           431      432       +1     
  Lines         12906    12920      +14     
  Branches       1728     1731       +3     
============================================
- Hits           5925     5924       -1     
- Misses         6280     6294      +14     
- Partials        701      702       +1     
Components Coverage Δ
sentinel-adapter 43.00% <0.00%> (-0.23%) ⬇️
sentinel-cluster 23.71% <ø> (ø)
sentinel-core 59.62% <ø> (-0.02%) ⬇️
sentinel-extension 46.19% <ø> (ø)
sentinel-logging 54.54% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LearningGp LearningGp added the to-review To review label May 29, 2024
@24kpure
Copy link
Contributor Author

24kpure commented Jun 14, 2024

@sczyh30 @jasonjoo2010 @brotherlu-xcq @LearningGp
I have raised mr(#3149) for a year so that sentinel default branch changed to 1.8.
Maybe reviewer can be faster this time,thanks~

1 similar comment
@24kpure
Copy link
Contributor Author

24kpure commented Jun 21, 2024

@sczyh30 @jasonjoo2010 @brotherlu-xcq @LearningGp
I have raised mr(#3149) for a year so that sentinel default branch changed to 1.8.
Maybe reviewer can be faster this time,thanks~

@24kpure
Copy link
Contributor Author

24kpure commented Aug 20, 2024

As a mature open source project, PR should be handled in a timely manner, rather than being shelved year after year. I am not sure whether this project is still maintained, or only people within Alibaba can get the review. Open source is not just for KPI, at least there should be enthusiasm, right?

@LearningGp
Copy link
Collaborator

As a mature open source project, PR should be handled in a timely manner, rather than being shelved year after year. I am not sure whether this project is still maintained, or only people within Alibaba can get the review. Open source is not just for KPI, at least there should be enthusiasm, right?

I'm sorry, this was indeed my oversight. The review for this PR has already been completed in the related PR, and it can be merged directly.

@LearningGp LearningGp merged commit b78b09d into alibaba:1.8 Aug 20, 2024
9 of 10 checks passed
@24kpure
Copy link
Contributor Author

24kpure commented Aug 21, 2024

Apologize for my recklessness. I still like sentinel ~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
to-review To review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants