-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sentinel can feel exception though application has configured E… #3409
Conversation
@sczyh30 @jasonjoo2010 @brotherlu-xcq @LearningGp |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 1.8 #3409 +/- ##
============================================
- Coverage 45.90% 45.85% -0.06%
+ Complexity 2147 2146 -1
============================================
Files 431 432 +1
Lines 12906 12920 +14
Branches 1728 1731 +3
============================================
- Hits 5925 5924 -1
- Misses 6280 6294 +14
- Partials 701 702 +1
☔ View full report in Codecov by Sentry. |
@sczyh30 @jasonjoo2010 @brotherlu-xcq @LearningGp |
1 similar comment
@sczyh30 @jasonjoo2010 @brotherlu-xcq @LearningGp |
As a mature open source project, PR should be handled in a timely manner, rather than being shelved year after year. I am not sure whether this project is still maintained, or only people within Alibaba can get the review. Open source is not just for KPI, at least there should be enthusiasm, right? |
I'm sorry, this was indeed my oversight. The review for this PR has already been completed in the related PR, and it can be merged directly. |
Apologize for my recklessness. I still like sentinel ~ |
Describe what this PR does / why we need it
sentinel can feel exception though application has configured ExceptionHandler
Does this pull request fix one issue?
#3141
#3149
Describe how you did it
Add a class SentinelExceptionAware which implement HandlerExceptionResolver and put exception into request.
Describe how to verify it
UT & add it in my project
Special notes for reviews
Thanks for your work.