-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sentinel-transport):make command center thread daemon #2181
Conversation
|
There are many place use For example: Line 65 in 2c12b07
Line 69 in 2c12b07
Line 50 in 2c12b07
Line 40 in 2c12b07
Line 51 in 2c12b07
Line 42 in 2c12b07
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@@ -48,7 +48,7 @@ | |||
|
|||
@SuppressWarnings("PMD.ThreadPoolCreationRule") | |||
private static final ExecutorService pool = Executors.newFixedThreadPool(10, | |||
new NamedThreadFactory("dubbo-consumer-pool")); | |||
new NamedThreadFactory("dubbo-consumer-pool", true)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For demo maybe it's not needed (waiting may be needed)?
Thanks for contributing. |
* feat:make command center thread daemon * feat:make all NamedThreadFactory thread daemon
* feat:make command center thread daemon * feat:make all NamedThreadFactory thread daemon
* feat:make command center thread daemon * feat:make all NamedThreadFactory thread daemon
* feat:make command center thread daemon * feat:make all NamedThreadFactory thread daemon
Describe what this PR does / why we need it
make sentinel client close resources more easier and elegant
Does this pull request fix one issue?
#2178
Describe how you did it
make commad center thread daemon
Describe how to verify it
Special notes for reviews