Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(interactive): Resolve the dependency problem between compiler and interactive SDK #4284

Merged
merged 4 commits into from
Oct 11, 2024

Conversation

zhanglei1949
Copy link
Collaborator

@zhanglei1949 zhanglei1949 commented Oct 11, 2024

The Interactive SDK and compiler both rely on gaia-ir-proto, including the protoc-generated classes. Previously, we used the maven-shade-plugin to shade the protoc files from the Interactive SDK, but this led to other build issues, as noted in PR #4255.

In this PR, we address the problem by adding an additional jar classifier, no-gaia-ir, which can be easily utilized by the compiler.

Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
@zhanglei1949
Copy link
Collaborator Author

TODO: We need to wait Interactive Java SDK 0.4.2 available in maven central repo, to pass the CI check.

Copy link
Contributor

github-actions bot commented Oct 11, 2024

Please check the preview of the documentation changes at
https://9d40094d.graphscope-docs-preview.pages.dev

@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.96%. Comparing base (ae4e9a2) to head (b8eece6).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4284   +/-   ##
=======================================
  Coverage   36.96%   36.96%           
=======================================
  Files         126      126           
  Lines       13235    13235           
=======================================
  Hits         4892     4892           
  Misses       8343     8343           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae4e9a2...b8eece6. Read the comment docs.

@zhanglei1949 zhanglei1949 merged commit 44599e4 into alibaba:main Oct 11, 2024
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants