Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bucket size #533

Merged
merged 2 commits into from
Feb 27, 2023
Merged

Fix bucket size #533

merged 2 commits into from
Feb 27, 2023

Conversation

xieyxclack
Copy link
Collaborator

As the title says.
Note that if one of the bucket is empty, the func np.concatenate might return float value array when concatenating [IntList, EmptyList, ...,]

@xieyxclack xieyxclack requested a review from qbc2016 February 27, 2023 04:33
@xieyxclack xieyxclack added bug Something isn't working Tree labels Feb 27, 2023
qbc2016
qbc2016 approved these changes Feb 27, 2023
View reviewed changes
Copy link
Collaborator

@qbc2016 qbc2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xieyxclack xieyxclack merged commit dbabfc5 into alibaba:master Feb 27, 2023
@xieyxclack xieyxclack deleted the fix_bucket_siz branch February 27, 2023 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qbc2016 qbc2016 qbc2016 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working Tree
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xieyxclack @qbc2016