Minor fixes for GitHub workflow action and the mean/std values of DataTransforms #513
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr includes two minor fixes:
test_act
: frompull_request: types: [opened, synchronize, edited]
toschedule: cron: '0 8 * * 0'
. It implies thattest_act
would no longer be triggered when someone gives a pull request, it would only be triggered once a week. The reasons for this modification are:test_act
and causes the unnecessary resource cost;test_atc
is just a unit-test for one specific FL-NLP application but not a general functionality, therefore most of the developments would be changed its correctness.test_atc
requires more packages such as Rouge and METEOR. Considering that these packages are only used in NLP applications, we don't include these packages in the environment. Thus we perform this unit-test via GitHub workflow action (which is easier to include the package installation during testing) rather than running it via Jenkins. Latertest_atc
can be moved to our server when these requirements have been installed.mean=[0.9637], std=[0.1592]
. These values are calculated by ourselves and are similar to those provided by other researchers.mean= [0.4914, 0.4822, 0.4465], std= [0.2470, 0.2435, 0.2616]
, which is borrowed from the value of mean, std in cifar-10 facebookarchive/fb.resnet.torch#180mean= [0.485, 0.456, 0.406], std= [0.229, 0.224, 0.225]
, which are standard values calculated from ImageNetWe point out that when
BatchNorm
is adopted, the mean/std values of DataTransforms make little effect on the model performance. And we haven't changed the yaml files of benchmarking (those underFederatedScope/benchmark/
).