Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new defense algo and sampler #512

Merged
merged 7 commits into from
Feb 6, 2023
Merged

Add new defense algo and sampler #512

merged 7 commits into from
Feb 6, 2023

Conversation

xieyxclack
Copy link
Collaborator

The modifications included in this pr:

  • Add a new sampler ResponsivenessRealtedSampler
  • Add defense algo Krum:
    • To test the effectiveness of Krum, I add a gaussian attacker and change the expected types of cfg.attack.attacker_id from int to int/list, please double check this @Osier-Yi
    • And to fix the issue caused by merging int and list configuration items, I add a forced replacement rule to yacs, please double check this @yxdyc

BTM, these features have been developed and pushed into the branch submit_dev_branch before. This pr focuses on how to add a unit test for ensuring their effectiveness and promotes further development.

@xieyxclack xieyxclack requested a review from yxdyc February 6, 2023 11:19
Copy link
Collaborator

@yxdyc yxdyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yxdyc yxdyc merged commit f9df0a4 into master Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants