Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pfedhpo and fts #509

Merged
merged 12 commits into from
Feb 14, 2023
Merged

pfedhpo and fts #509

merged 12 commits into from
Feb 14, 2023

Conversation

TheSunWillRise
Copy link
Contributor

I rearranged the codes for FTS and our HPN, as well as removed the redundant exp scripts.

@rayrayraykk rayrayraykk self-requested a review February 3, 2023 06:34
@rayrayraykk rayrayraykk added the FedHPO FedHPO related label Feb 3, 2023
rayrayraykk
rayrayraykk reviewed Feb 3, 2023
View reviewed changes
scripts/example_configs/pfedhpo/mini_graph_dc/pfedhpo.yaml
hpo:
scheduler: pfedhpo
num_workers: 0
pfedhpo:
Copy link
Collaborator

@rayrayraykk rayrayraykk Feb 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not find the key in cfg.hpo, which might raise error.

rayrayraykk
rayrayraykk reviewed Feb 9, 2023
View reviewed changes
Copy link
Collaborator

@rayrayraykk rayrayraykk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if there are no changes in worker_builder, how could you run an FTS worker or pfedhpo worker?

@rayrayraykk rayrayraykk mentioned this pull request Feb 10, 2023
Open
@rayrayraykk
Copy link
Collaborator

rayrayraykk commented Feb 10, 2023 •
edited
Loading

Please solve RuntimeError: stack expects a non-empty TensorList when running the scripts.

rayrayraykk
rayrayraykk reviewed Feb 10, 2023
View reviewed changes
Copy link
Collaborator

@rayrayraykk rayrayraykk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I try to run the scripts, I always get {'Role': 'Client #xxx', 'Hyperparams': None}, could you fix this?

federatedscope/autotune/pfedhpo/utils.py Outdated Show resolved Hide resolved
federatedscope/autotune/pfedhpo/utils.py Outdated Show resolved Hide resolved
@rayrayraykk
Copy link
Collaborator

Please resolve the conflicts and pass the UT.

joneswong
joneswong approved these changes Feb 14, 2023
View reviewed changes
Copy link
Collaborator

@joneswong joneswong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joneswong joneswong merged commit 2b6449a into alibaba:master Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rayrayraykk rayrayraykk rayrayraykk left review comments

@joneswong joneswong joneswong approved these changes

Assignees
No one assigned
Labels
FedHPO FedHPO related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheSunWillRise @rayrayraykk @joneswong