Refactor vertical FL module for XGB-base #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
xieyxclack
commented
Jan 3, 2023
•
xieyxclack
commented
- dataset & dataloader
- XGBServer / XGBClient
- trainer_wrapper / evalution_wrapper
- VerticalTrainer
qbc2016
reviewed
Jan 3, 2023
| @@ -54,7 +54,6 @@ class Abalone: | |||
|
|
|||
| def __init__(self, | |||
| root, | |||
| name, | |||
There was a problem hiding this comment.
Maybe we should also remove the "name" line (i.e., line 39) in "Arguments" of the class.
|
LGTM. |
xieyxclack
changed the title
qbc2016
reviewed
Jan 16, 2023
| @@ -132,115 +71,49 @@ def sample_data(self, index=None): | |||
| # label-owner calls self.preparation() | |||
There was a problem hiding this comment.
The annotate should be modified or deleted.
qbc2016
reviewed
Jan 16, 2023
| sender=self.ID, | ||
| state=self.state, | ||
| receiver=receiver, | ||
| content=batch_index)) | ||
|
|
||
| # other clients receive the data-sample information | ||
| # other clients also call self.preparation() |
qbc2016
reviewed
Jan 16, 2023
| receiver=[ | ||
| each | ||
| for each in list(self.comm_manager.neighbors.keys()) | ||
| if each != self.server_id |
There was a problem hiding this comment.
Here should add the condition that "and each != self.ID", otherwise label owner would send it twice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.