Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add distributed mode for xgb algo #471

Merged
merged 3 commits into from
Dec 9, 2022
Merged

Conversation

qbc2016
Copy link
Collaborator

@qbc2016 qbc2016 commented Dec 9, 2022

  • as the title says
  • add feature importance to log info

@xieyxclack xieyxclack self-requested a review December 9, 2022 06:54
@xieyxclack xieyxclack added the Tree label Dec 9, 2022
xieyxclack
xieyxclack previously approved these changes Dec 9, 2022
Copy link
Collaborator

@xieyxclack xieyxclack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some minor suggestions can be found in line

@@ -125,15 +128,21 @@ def sample_data(self, index=None):
def callback_func_for_model_para(self, message: Message):
self.lambda_, self.gamma, self.num_of_trees, self.max_tree_depth \
= message.content

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add some explanations here

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.


echo "Test distributed mode with XGB..."

### server owns global test data
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it support the situation that server owns global test data?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So shall we remove the ''redundant'' code here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified.

@xieyxclack xieyxclack merged commit 8dccbb2 into alibaba:master Dec 9, 2022
@qbc2016 qbc2016 deleted the dev_distr_xgb branch December 12, 2022 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants