Update xgb algo files #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
qbc2016
commented
Nov 21, 2022
qbc2016
commented
- refine each client's test data
- refine testing procedure
- add 3 more datasets for xgb algo
…bel form 0 to -1 or not
xieyxclack
reviewed
Nov 22, 2022
|
|
||
| Arguments: | ||
| root (str): root path | ||
| name (str): name of dataset, ‘adult’ or ‘xxx’ |
There was a problem hiding this comment.
Ah, sry.., it should be 'blog'
|
|
||
| Arguments: | ||
| root (str): root path | ||
| name (str): name of dataset, ‘adult’ or ‘xxx’ |
| @@ -0,0 +1,155 @@ | |||
| import logging | |||
There was a problem hiding this comment.
It seems that we can define a BaseDataset for vertical dataset
| } | ||
| if tree_num + 1 < self.client.num_of_trees: | ||
| # TODO: add feedback during training | ||
| ''' |
There was a problem hiding this comment.
Please remove this if it is redundant
|
|
||
| tree_num = 0 | ||
| self.test_for_root(tree_num) | ||
| def evaluation(self): |
There was a problem hiding this comment.
Can Test_base support multiple (>2) clients?
| if self.own_label: | ||
| self.test_y = self.data['test']['y'] | ||
|
|
||
| self.test_z = np.zeros(self.test_x.shape[0]) |
There was a problem hiding this comment.
It is exactly the result outputted by the model on test data, I'll change the name.
rayrayraykk
reviewed
Nov 22, 2022
There was a problem hiding this comment.
The dataset part looks good to me. As the XGB module is independent, please consider adding it to SPHINX.
| @@ -1,6 +1,10 @@ | |||
| import numpy as np | |||
rayrayraykk
reviewed
Nov 22, 2022
| feature_partition=feature_partition, | ||
| tr_frac=splits[0], | ||
| download=True, | ||
| seed=1234, |
There was a problem hiding this comment.
We might maintain a global seed for data generation as it has been set in here. @xieyxclack @yxdyc @DavdGao
xieyxclack
approved these changes
Nov 22, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.