Add more models and datasets from external packages. #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rayrayraykk
commented
Apr 27, 2022
•
rayrayraykk
commented
- Add pre-trained transformers to NLP models.
- Add datasets from hugging face.
- add datasets from openml.
rayrayraykk
changed the title
yxdyc
reviewed
May 7, 2022
| @@ -42,11 +42,13 @@ RUN conda install -y pytorch==1.8.0 torchvision==0.9.0 torchaudio==0.8.0 cudatoo | |||
| # for graph | |||
| RUN conda install -y pyg==2.0.1 -c pyg \ | |||
| && conda install -y rdkit=2021.09.4 -c conda-forge \ | |||
| && conda install -y nltk \ | |||
There was a problem hiding this comment.
nltk should be put at the back of the line (the NLP part below)?
There was a problem hiding this comment.
NLTK is used for generating features of some graph datasets.
| local_update_steps: 1 | ||
| total_round_num: 400 | ||
| batch_or_epoch: 'epoch' | ||
| client_num: 1 |
There was a problem hiding this comment.
why this baseline uses only 1 client?
| DATA_LOAD_FUNCS = { | ||
| 'torchvision': load_torchvision_data, | ||
| 'torchtext': load_torchtext_data, | ||
| 'torchaudio': load_torchaudio_data, | ||
| 'torch_geometric': load_torch_geometric_data | ||
| 'torch_geometric': load_torch_geometric_data, | ||
| 'datasets': load_datasets_data, |
There was a problem hiding this comment.
the name "datasets" is too general, how about huggingface_datasets
| federate: | ||
| mode: standalone | ||
| local_update_steps: 1 | ||
| total_round_num: 400 |
There was a problem hiding this comment.
In centralized mode, the fine-tuning often takes only a few epochs. Maybe we can set the total_round_num to be in the order of dozens, e.g., 40?
yxdyc
approved these changes
May 7, 2022
AnthonyXuan
pushed a commit
to AnthonyXuan/FederatedScope
that referenced
this pull request
Aug 10, 2023
Add more models and datasets from external packages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.