Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Refactor FedRunner and optimize trainer module #408

Closed
wants to merge 29 commits into from

Conversation

rayrayraykk
Copy link
Collaborator

@rayrayraykk rayrayraykk commented Oct 24, 2022

What's changed

  1. Runner -> StandaloneRunner + DistributedRunner
  2. Add README for Trainer module
  3. Make num_val_batch, num_total_train_batch.... (related to cfg) as @Property method (Users could still use setattr or = to change these values, but the changes will make the @property function invalid.)
@property
def num_total_train_batch(self):
    if self.get('num_total_train_batch'):
        return self.get('num_total_train_batch')
    return self._calculate_batch_epoch_num(mode='train')[3]
  1. Optimize doc string for hook functions and API ref.
  2. Bind each metric with one and only key THE_LARGER_THE_BETTER
  3. Move functions in utils to xxx.utils

Details

Coming soon.

@rayrayraykk rayrayraykk added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 24, 2022
@rayrayraykk rayrayraykk changed the title Refactor FedRunner and optimize trainer module [Feature] Refactor FedRunner and optimize trainer module Oct 25, 2022
@rayrayraykk
Copy link
Collaborator Author

Dicard this PR for the changes containing in #415 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant