Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix for scripts #319

Merged
merged 1 commit into from
Aug 15, 2022
Merged

bugfix for scripts #319

merged 1 commit into from
Aug 15, 2022

Conversation

xieyxclack
Copy link
Collaborator

As the title says, including:

  • invalid path
  • typos
  • the reported round in evaluation
  • add refs for fedscale

@xieyxclack xieyxclack added the documentation Improvements or additions to documentation label Aug 12, 2022
@xieyxclack xieyxclack requested review from Osier-Yi and yxdyc August 12, 2022 08:11
yxdyc
yxdyc approved these changes Aug 12, 2022
View reviewed changes
Copy link
Collaborator

@yxdyc yxdyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Osier-Yi
Copy link
Collaborator

LGTM

@Osier-Yi Osier-Yi merged commit d0c7aaa into alibaba:master Aug 15, 2022
@xieyxclack xieyxclack deleted the scripts_minor_fix branch August 15, 2022 09:16
Schichael pushed a commit to Schichael/FederatedScope_thesis that referenced this pull request Sep 7, 2022
@xieyxclack
bugfix for scripts (alibaba#319)
9f244f3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yxdyc yxdyc yxdyc approved these changes

@Osier-Yi Osier-Yi Awaiting requested review from Osier-Yi

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xieyxclack @Osier-Yi @yxdyc