[bugfix] Fix one-shot exp utils #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rayrayraykk
changed the title
rayrayraykk
changed the title
rayrayraykk
changed the title
joneswong
reviewed
Aug 18, 2022
| @@ -27,8 +27,8 @@ def get_next_iteration(self, iteration, iteration_kwargs={}): | |||
| # number of configurations in that bracket | |||
| n0 = int(np.floor((self.max_SH_iter) / (s + 1)) * self.eta**s) | |||
| ns = [max(int(n0 * (self.eta**(-i))), 1) for i in range(s + 1)] | |||
| if os.path.exists(self.working_folder): | |||
| self.clear_cache() | |||
| # if os.path.exists(self.working_folder): | |||
There was a problem hiding this comment.
so how to avoid restoring from the ckpts of previous SHA's attempts?
There was a problem hiding this comment.
Fixed, but I wonder as we remove ckpts but the Z yaml file will also be updated by the next SHA's attempts. How can we avoid this? Maybe we need a discussion.
Schichael
pushed a commit
to Schichael/FederatedScope_thesis
that referenced
this pull request
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says.