Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init the pFL-bench scripts #149

Merged
merged 4 commits into from
Jun 13, 2022
Merged

Conversation

yxdyc
Copy link
Collaborator

@yxdyc yxdyc commented Jun 10, 2022

init the pFL-bench scripts and README.

@yxdyc yxdyc added the enhancement New feature or request label Jun 10, 2022
@yxdyc yxdyc requested review from xieyxclack and DavdGao June 10, 2022 08:23
Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.
Considering the code is actually running with the other branch, it is suggested to copy all these scripts into the specific branch.

@yxdyc
Copy link
Collaborator Author

yxdyc commented Jun 10, 2022

It looks good to me. Considering the code is actually running with the other branch, it is suggested to copy all these scripts into the specific branch.

Yes, all these scripts are in the another branch. As the README said You can find the full scripts from the another [branch](https://github.com/alibaba/FederatedScope/tree/Feature/pfl_bench/scripts/personalization_exp_scripts/pfl_bench)

@DavdGao
Copy link
Collaborator

DavdGao commented Jun 10, 2022

I'm not sure, maybe it's better to place the scripts in the same directory for both master and Feature/pfl_bench?

@yxdyc
Copy link
Collaborator Author

yxdyc commented Jun 10, 2022

I'm not sure, maybe it's better to place the scripts in the same directory for both master and Feature/pfl_bench?

If in master, this PR will involves ~600 files and 5w+ codes. So I put them into a zip file, and refer readers to the file link as README said: You can find the full scripts from the another [branch](https://github.com/alibaba/FederatedScope/tree/Feature/pfl_bench/scripts/personalization_exp_scripts/pfl_bench) or the packed small zip [file](https://federatedscope.oss-cn-beijing.aliyuncs.com/pfl_bench_scripts.zip), in which we organize the scripts for all the methods and all the datasets as multiple directories named by dataset name.

Copy link
Collaborator

@xieyxclack xieyxclack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xieyxclack xieyxclack merged commit 3452a20 into alibaba:master Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants