[Feature] Enabled un-seen clients case to check the participation generalization gap #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…upload/download bytes, convergence rounds and time
yxdyc
force-pushed
the
Feature/unseen_clients
branch
from
875008f to
88ad802
Compare
xieyxclack
reviewed
Jul 13, 2022
federatedscope/core/fed_runner.py
Outdated
| self.server = self._setup_server() | ||
| self.server.unseen_clients_id = unseen_clients_id |
There was a problem hiding this comment.
IMO, we have better not modify the attributes of server/client in fed_runner
There was a problem hiding this comment.
moved it into the setup_server() as sub action of init
federatedscope/core/fed_runner.py
Outdated
| @@ -102,6 +115,8 @@ def _setup_for_standalone(self): | |||
| for client_id in range(1, self.cfg.federate.client_num + 1): | |||
| self.client[client_id] = self._setup_client( | |||
| client_id=client_id, client_model=self._shared_client_model) | |||
| if client_id in unseen_clients_id: | |||
| self.client[client_id].is_unseen_client = True | |||
There was a problem hiding this comment.
moved it into the setup_server() as sub action of init
federatedscope/core/sampler.py
Outdated
| self.client_state[indices] = 1 | ||
| elif state == 'working': | ||
| self.client_state[indices] = 0 | ||
| if not isinstance(indices, list): |
There was a problem hiding this comment.
Shall we cover np.array here?
There was a problem hiding this comment.
modified accordingly, besides, we used another state named "unseen"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled un-seen clients simulation, such that we can check the participation generalization gap, refer ICLR'22, What Do We Mean by Generalization in Federated Learning?
This PR is based on the another PR (enhanced monitor #90)