This repository has been archived by the owner on Feb 8, 2023. It is now read-only.
forked from opencontainers/runc
-
Notifications
You must be signed in to change notification settings - Fork 4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ller in runc MBA Software Controller feature is introduced in Linux kernel v4.18. It is a software enhancement to mitigate some limitations in MBA which describes in kernel documentation. It also makes the interface more user friendly - we could specify memory bandwidth in "MBps" (Mega Bytes per second) as well as in "percentages". The kernel underneath would use a software feedback mechanism or a "Software Controller" which reads the actual bandwidth using MBM counters and adjust the memory bandwidth percentages to ensure: "actual memory bandwidth < user specified memory bandwidth". We could enable this feature through mount option "-o mba_MBps": mount -t resctrl resctrl -o mba_MBps /sys/fs/resctrl In runc, we handle both memory bandwidth schemata in unified format: "MB:<cache_id0>=bandwidth0;<cache_id1>=bandwidth1;..." The unit of memory bandwidth is specified in "percentages" by default, and in "MBps" if MBA Software Controller is enabled. For more information about Intel RDT and MBA Software Controller: https://www.kernel.org/doc/Documentation/x86/intel_rdt_ui.txt Signed-off-by: Xiaochen Shen <[email protected]>
Signed-off-by: Lifubang <[email protected]>
After talking to Rohit, he mentioned that he wasn't aware he was still a maintainer (and that his maintainership was grandfathered from his Docker maintainership). He's moved on to other projects now, and thus said he would happily step down as maintainer. (Since he's stepping down voluntarily, this doesn't require a mailing-list vote.) Thanks for all of your hard work, Rohit! Signed-off-by: Aleksa Sarai <[email protected]>
After discussion with Victor, he mentioned that he wanted to rescind his maintainership a few years ago (due to a change in priorities and what he's been working on) but wasn't sure what the right process is. Thanks for your hard work Victor! Signed-off-by: Aleksa Sarai <[email protected]>
This commit modifies check-config.sh to keep up with current kernel config. Signed-off-by: Kenta Tada <[email protected]>
regression introduced by 87a1889 Signed-off-by: Giuseppe Scrivano <[email protected]>
When built with nokmem we explicitly are disabling support for kmemcg, but it is a strict specification requirement that if we cannot fulfil an aspect of the container configuration that we error out. Completely ignoring explicitly-requested kmemcg limits with nokmem would undoubtably lead to problems. Fixes: 6a2c155 ("libcontainer: ability to compile without kmem") Signed-off-by: Aleksa Sarai <[email protected]>
Signed-off-by: JoeWrightss <[email protected]>
Signed-off-by: JoeWrightss <[email protected]>
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update with opencontainer/runc with new feature and bugfix
opencontainers#1952
opencontainers#1945
opencontainers#1943
opencontainers#1942
opencontainers#1940
opencontainers#1939