Skip to content
This repository has been archived by the owner on Feb 8, 2023. It is now read-only.

Update 2019 0107 #18

Merged
merged 9 commits into from
Jan 7, 2019
Merged

Update 2019 0107 #18

merged 9 commits into from
Jan 7, 2019

Conversation

Ace-Tang
Copy link
Collaborator

@Ace-Tang Ace-Tang commented Jan 7, 2019

xiaochenshen and others added 9 commits January 7, 2019 10:38
…ller in runc

MBA Software Controller feature is introduced in Linux kernel v4.18.
It is a software enhancement to mitigate some limitations in MBA which
describes in kernel documentation. It also makes the interface more user
friendly - we could specify memory bandwidth in "MBps" (Mega Bytes per
second) as well as in "percentages".

The kernel underneath would use a software feedback mechanism or a
"Software Controller" which reads the actual bandwidth using MBM
counters and adjust the memory bandwidth percentages to ensure:
"actual memory bandwidth < user specified memory bandwidth".

We could enable this feature through mount option "-o mba_MBps":
mount -t resctrl resctrl -o mba_MBps /sys/fs/resctrl

In runc, we handle both memory bandwidth schemata in unified format:
"MB:<cache_id0>=bandwidth0;<cache_id1>=bandwidth1;..."
The unit of memory bandwidth is specified in "percentages" by default,
and in "MBps" if MBA Software Controller is enabled.

For more information about Intel RDT and MBA Software Controller:
https://www.kernel.org/doc/Documentation/x86/intel_rdt_ui.txt

Signed-off-by: Xiaochen Shen <[email protected]>
After talking to Rohit, he mentioned that he wasn't aware he was still a
maintainer (and that his maintainership was grandfathered from his
Docker maintainership). He's moved on to other projects now, and thus
said he would happily step down as maintainer. (Since he's stepping down
voluntarily, this doesn't require a mailing-list vote.)

Thanks for all of your hard work, Rohit!

Signed-off-by: Aleksa Sarai <[email protected]>
After discussion with Victor, he mentioned that he wanted to rescind
his maintainership a few years ago (due to a change in priorities and
what he's been working on) but wasn't sure what the right process is.

Thanks for your hard work Victor!

Signed-off-by: Aleksa Sarai <[email protected]>
This commit modifies check-config.sh to keep up with current kernel config.

Signed-off-by: Kenta Tada <[email protected]>
regression introduced by 87a1889

Signed-off-by: Giuseppe Scrivano <[email protected]>
When built with nokmem we explicitly are disabling support for kmemcg,
but it is a strict specification requirement that if we cannot fulfil an
aspect of the container configuration that we error out.

Completely ignoring explicitly-requested kmemcg limits with nokmem would
undoubtably lead to problems.

Fixes: 6a2c155 ("libcontainer: ability to compile without kmem")
Signed-off-by: Aleksa Sarai <[email protected]>
Signed-off-by: JoeWrightss <[email protected]>
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 6 committers have signed the CLA.

✅ lifubang
❌ xiaochenshen
❌ cyphar
❌ KentaTada
❌ giuseppe
❌ JoeWrightss
You have signed the CLA already but the status is still pending? Let us recheck it.

@rudyfly rudyfly merged commit f8f73f6 into alibaba-archive:develop Jan 7, 2019
@Ace-Tang Ace-Tang deleted the update_2019_0107 branch January 7, 2019 05:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants