Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Method unshape is not working #6

Open
alhoqbani opened this issue Jul 7, 2017 · 0 comments
Open

Method unshape is not working #6

alhoqbani opened this issue Jul 7, 2017 · 0 comments
Labels
bug class: Normalise help wanted

Comments

@alhoqbani
Copy link
Owner

mehtod unshape is not working.

It should replace Arabic letter for its joined form to the standalone shape.
e.g. أحمد should be أ ح م د with no spaces !!

it failed to do the replacement when passed a string. However, it can replace a single character which is not useful.

Also, the use case for this method is not clear to me.
alhoqbani added a commit that referenced this issue Jul 7, 2017
@alhoqbani
Create a test for unshape method from the Normalise class.
91b7378 
This test is failing and skipped for now. The mehtod does not replace
the text as explaind in #6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug class: Normalise help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alhoqbani