Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove index on application create call in beta composer #122

Merged

Conversation

uhudo
Copy link
Contributor

@uhudo uhudo commented Nov 1, 2024

Proposed Changes

  • There is an error when using creating an application with beta/composer.py because the parameter index is passed to ApplicationCreateTxn.
  • Remove passing index in beta/composer.py when creating an application.

@aorumbayev
Copy link
Contributor

Hello @uhudo thank you for submitting the PR, the beta namespace is not the final implementation accommodating full feature parity with algokit-utils-ts. There is a significant rework going on to get algokit-utils-py up to speed with all latest algokit-utils-ts public interfaces and abstractions. To track progress refer here https://github.com/algorandfoundation/algokit-internal/issues/42. I will merge your PR but be aware that from v3 of py sdk there may be further breaking changes in beta namespace, as for all of the existing stateless functions in v2 -> similar to utils-ts they will be supplemented with detailed deprecation guides

@aorumbayev aorumbayev self-requested a review November 1, 2024 13:05
@aorumbayev aorumbayev merged commit e4a6435 into algorandfoundation:main Nov 1, 2024
4 checks passed
@uhudo
Copy link
Contributor Author

uhudo commented Nov 1, 2024

Hey @aorumbayev, thanks for the info. I wasn't aware of the ongoing changes. The link you put to track the progress is to an algokit-internal repo, which is giving me 404 error.

@aorumbayev
Copy link
Contributor

aorumbayev commented Nov 1, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants