-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bootstrap): Improving robustness and test coverage for bootstrap poetry command #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robdmoore
changed the title
fix(bootstrap): Improving robustness and test coverage for bootstrap poetry command
[WIP] fix(bootstrap): Improving robustness and test coverage for bootstrap poetry command
Dec 13, 2022
robdmoore
force-pushed
the
bootstrap-robustness
branch
from
December 13, 2022 17:43
2aeb3e7
to
ce8982a
Compare
robdmoore
force-pushed
the
bootstrap-robustness
branch
from
December 14, 2022 10:46
ce8982a
to
8e08e3f
Compare
Coverage Report
|
…poetry command Uses system python to invoke pipx rather than the current venv
…strap env command
… initialising a template
BREAKING CHANGE: --ok-exit-code no longer exists on algokit bootstrap poetry, no need for copier templates to call algokit now so no need for this feature
feat(bootstrap): try using system Python versions for pipx, in case it was installed that way
achidlow
force-pushed
the
bootstrap-robustness
branch
from
December 16, 2022 04:36
e565d71
to
4f6c257
Compare
achidlow
force-pushed
the
bootstrap-robustness
branch
from
December 16, 2022 05:02
4f6c257
to
687667c
Compare
…ils. this allows any lock files to be committed
robdmoore
changed the title
[WIP] fix(bootstrap): Improving robustness and test coverage for bootstrap poetry command
fix(bootstrap): Improving robustness and test coverage for bootstrap poetry command
Dec 16, 2022
mzaatar
approved these changes
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses system python to invoke pipx rather than the current venv
@achidlow to throw a spanner in the works, I don't think this will consistently work afterall. Somehow my windows setup has a non symlinked python.exe in .venv and no python.exe/python3.exe in the sys.base_prefix :O. Let's look together on Thursday?