Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bootstrap): Improving robustness and test coverage for bootstrap poetry command #89

Merged
merged 10 commits into from
Dec 16, 2022

Conversation

robdmoore
Copy link
Contributor

Uses system python to invoke pipx rather than the current venv

@achidlow to throw a spanner in the works, I don't think this will consistently work afterall. Somehow my windows setup has a non symlinked python.exe in .venv and no python.exe/python3.exe in the sys.base_prefix :O. Let's look together on Thursday?

@robdmoore robdmoore changed the title fix(bootstrap): Improving robustness and test coverage for bootstrap poetry command [WIP] fix(bootstrap): Improving robustness and test coverage for bootstrap poetry command Dec 13, 2022
@robdmoore robdmoore force-pushed the bootstrap-robustness branch from 2aeb3e7 to ce8982a Compare December 13, 2022 17:43
@robdmoore robdmoore linked an issue Dec 13, 2022 that may be closed by this pull request
@robdmoore robdmoore force-pushed the bootstrap-robustness branch from ce8982a to 8e08e3f Compare December 14, 2022 10:46
@github-actions
Copy link

github-actions bot commented Dec 14, 2022

Coverage

Coverage Report
FileStmtsMissCoverMissing
src/algokit
   __init__.py15753%6–13, 17–24, 32–34
   __main__.py220%1–3
src/algokit/cli
   init.py1651690%56, 203–204, 235, 238–240, 251, 289, 326, 335–337, 340–345, 360
src/algokit/core
   bootstrap.py1001684%74, 94, 149, 152, 158–172
   click_extensions.py472057%40–43, 50, 56, 67–68, 73–74, 79–80, 91, 104–114
   conf.py27967%10–17, 24, 26
   log_handlers.py68987%44–45, 50–51, 63, 112–116, 125
   proc.py44198%94
   sandbox.py106793%82, 147, 163, 178–180, 195
TOTAL9078790% 

Tests Skipped Failures Errors Time
102 0 💤 0 ❌ 0 🔥 9.415s ⏱️

robdmoore and others added 6 commits December 16, 2022 12:36
…poetry command

Uses system python to invoke pipx rather than the current venv
BREAKING CHANGE: --ok-exit-code no longer exists on algokit bootstrap poetry, no need for copier templates to call algokit now so no need for this feature
feat(bootstrap): try using system Python versions for pipx, in case it was installed that way
@achidlow achidlow force-pushed the bootstrap-robustness branch from e565d71 to 4f6c257 Compare December 16, 2022 04:36
@achidlow achidlow force-pushed the bootstrap-robustness branch from 4f6c257 to 687667c Compare December 16, 2022 05:02
@robdmoore robdmoore changed the title [WIP] fix(bootstrap): Improving robustness and test coverage for bootstrap poetry command fix(bootstrap): Improving robustness and test coverage for bootstrap poetry command Dec 16, 2022
@achidlow achidlow merged commit a4a6823 into main Dec 16, 2022
@mzaatar mzaatar deleted the bootstrap-robustness branch December 16, 2022 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bootstrap a project (+ core dependencies)
3 participants