fix: adjust how we run npx, so it supports all windows versions #454
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #453
Proposed Changes
Rather than running
npx
using the path resolved by runningshutil.which("npx")
, executenpx.cmd
on windows systems andnpx
on all other systems. This approach is what is used when we runnpm
throughout the codebase (for example in bootstrap), so also has the nice benefit of keeping things consistent.