Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client generator fails on some Windows machines #453

Closed
neilcampbell opened this issue Mar 13, 2024 · 0 comments · Fixed by #454
Closed

Client generator fails on some Windows machines #453

neilcampbell opened this issue Mar 13, 2024 · 0 comments · Fixed by #454
Labels
bug Something isn't working

Comments

@neilcampbell
Copy link
Contributor

Subject of the issue

As reported on discord, the client generator fails on some Windows machines.

See https://discord.com/channels/491256308461207573/1217246027623694427

It appears that running shutil.which("npx") on some Windows machines returns to the path to npx not npx.cmd. If we try to execute npx using the returned path, it may not succeeded as npx is not a valid windows executable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: adjust how we run npx, so it supports all windows versions algorandfoundation/algokit-cli
1 participant
@neilcampbell