fix: docker compose ps parsing for version >= 2.21 (#336)

* fix: docker compose ps parsing for version >= 2.21 * simplify condition for parsing docker compose ps * Use startswith Co-authored-by: Adam Chidlow <[email protected]> * remove "data = []" * use splitlines Co-authored-by: Al <[email protected]> --------- Co-authored-by: Adam Chidlow <[email protected]> Co-authored-by: Al <[email protected]>
algorandfoundation · Oct 20, 2023 · 06ba5e9 · 06ba5e9 · github-actions · Oct 20, 2023
1 parent 288b561
commit 06ba5e9
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/src/algokit/core/sandbox.py b/src/algokit/core/sandbox.py
@@ -116,7 +116,14 @@ def ps(self, service_name: str | None = None) -> list[dict[str, Any]]:
         )
         if run_results.exit_code != 0:
             return []
-        data = json.loads(run_results.output)
+
+        # `docker compose ps --format json` on version < 2.21.0 outputs a JSON arary
+        if run_results.output.startswith("["):
+            data = json.loads(run_results.output)
+        # `docker compose ps --format json` on version >= 2.21.0 outputs seperate JSON objects, each on a new line
+        else:
+            data = [json.loads(line) for line in run_results.output.splitlines() if line]
+
         assert isinstance(data, list)
         return cast(list[dict[str, Any]], data)