This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
feat(Menu): add widget #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haroenv
reviewed
Aug 9, 2018
| @@ -1,46 +1,51 @@ | |||
| <template> | |||
| <div :class="suit()" v-if="state"> | |||
There was a problem hiding this comment.
Yes it fits since the full DOM widget is under the slot. It's just that we have now an extra (useless) div on top of the widget.
| exports[`custom default render renders correctly 1`] = ` | ||
|
|
||
| <div> | ||
| <div class> |
There was a problem hiding this comment.
Empty class, but not an issue I guess
There was a problem hiding this comment.
Yep but we do not care that much since it's the result of the custom render. I add a class only when canRefine is false.
|
We didn't pick the solution with the top level |
Haroenv
pushed a commit
to algolia/instantsearch
that referenced
this pull request
Dec 28, 2022
* feat(Menu): update props * feat(Menu): remove useless label props for slots * feat(Menu): add searchable as TODO * feat(Menu): update stories with more use cases * style: run Prettier * refactor(Menu): remove the className on the parent div * docs(Menu): update * fix(Menu): avoid the extra div
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the
Menuwidget.You can try the widget on Storybook.
Questions
One thing to note is that I scoped the top level
divof the widget under theslot. It avoids to still have the top level className when you completely rewrite the widget. But it introduce a top leveldivon top of the widget (see picture below). It can be removed when Vue will support a "Fragment" like component. Do we want to implement this behaviour on all the widgets?With default render
With custom render