fix(highlight-vdom): remove UMD entry points and add CommonJS #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahdayan
requested review from
dhayab,
FabienMotte,
francoischalifour and
Haroenv
Haroenv
approved these changes
Jul 13, 2022
sarahdayan
changed the title
sarahdayan
changed the title
Haroenv
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we agreed not to expose an UMD build for
highlight-vdomI forgot to remove the entry points for it. We don't need the package to be importable from CDNs.Also replaced themainfield with the ESM build. Right now, this is causing tools like ESLint and Jest not to find the package.Edit: I now compile the package into CommonJS and use it for
mainfor testing purposes—Jest doesn't natively works with ESM and setting it up requires Node 14, which we don't use in projects like InstantSearch.js.