Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(shared): make usable when there's no preact or react #13

Merged
merged 4 commits into from
Oct 10, 2022
Merged

fix(shared): make usable when there's no preact or react #13

merged 4 commits into from
Oct 10, 2022

Commits on Oct 10, 2022

  1. fix(shared): make usable when there's no preact or react 

    see algolia/angular-instantsearch#968, algolia/angular-instantsearch#967 and  algolia/instantsearch#5109
    @Haroenv
    Haroenv committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    5eab141 View commit details
    Browse the repository at this point in the history

  2. Update packages/shared/src/Renderer.ts 

    Co-authored-by: Sarah Dayan <[email protected]>
    @Haroenv @sarahdayan
    Haroenv and sarahdayan authored Oct 10, 2022
    Configuration menu
    Copy the full SHA
    04881fa View commit details
    Browse the repository at this point in the history

  3. avoid usage of JSX.IntrinsicElements, as it can fall back to empty in… 

    …terface

eg. in the case there's no JSX set (angular, vue)
    @Haroenv
    Haroenv committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    54f8783 View commit details
    Browse the repository at this point in the history

  4. add a bit more text

    @Haroenv
    Haroenv committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    c2ced29 View commit details
    Browse the repository at this point in the history