Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add extractChangelog to config #403

Merged
merged 6 commits into from
Nov 18, 2019

Conversation

kazupon
Copy link
Contributor

@kazupon kazupon commented Nov 8, 2019

In #388 , We can extract changelog for lerna-changelog, but when we use other changelog generating tool, we have to set updateChangelog = false.
In that case, when we execute shipjs release, we can't put changelog in GitHub Releases.

I've added new extractChangelog to config.

@eunjae-lee
Copy link
Contributor

@kazupon Thanks for the contribution!

I've made some changes and I'd appreciate if you could review it 🙂

c2e6ddd, 5494eeb: just some clean-up of what I've done before inconsistently
6eedfc6: I've left comments there.

@kazupon
Copy link
Contributor Author

kazupon commented Nov 11, 2019

@eunjae-lee
Thank you for your advice.
I've commented your comments.
I agree for your suggestion.

@eunjae-lee eunjae-lee merged commit 35605ec into algolia:master Nov 18, 2019
@eunjae-lee
Copy link
Contributor

@kazupon Thanks for the review :)
It's merged and it will probably be released tomorrow 🎉

Feel free to open a new PR which adds you as a contributor.

yarn contributors:add kazupon code

@kazupon kazupon deleted the feat/extract-changelog branch November 18, 2019 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants