fix: don't display steps for slack when there's no slack config (#294)

algolia · Oct 4, 2019 · eb1ab44 · eb1ab44
1 parent 0de5d68
commit eb1ab44
Show file tree

Hide file tree

Showing 3 changed files with 52 additions and 27 deletions.
diff --git a/packages/shipjs/src/step/prepare/notifyPrepared.js b/packages/shipjs/src/step/prepare/notifyPrepared.js
@@ -2,11 +2,18 @@ import { notifyPrepared } from '../../util/slack';
 import runStep from '../runStep';
 
 export default async ({ config, appName, version, pullRequestUrl }) =>
-  await runStep({ title: 'Notifying notifyPrepared to Slack' }, async () => {
-    await notifyPrepared({
-      config,
-      appName,
-      version,
-      pullRequestUrl,
-    });
-  });
+  await runStep(
+    {
+      title: 'Notifying notifyPrepared to Slack',
+      skipIf: () =>
+        !config.slackIncomingHook || !config.slack || !config.slack.prepared,
+    },
+    async () => {
+      await notifyPrepared({
+        config,
+        appName,
+        version,
+        pullRequestUrl,
+      });
+    }
+  );
diff --git a/packages/shipjs/src/step/release/notifyReleaseStart.js b/packages/shipjs/src/step/release/notifyReleaseStart.js
@@ -8,12 +8,21 @@ export default async ({
   latestCommitHash,
   latestCommitUrl,
 }) =>
-  await runStep({ title: 'Notifying releaseStart to Slack' }, async () => {
-    await notifyReleaseStart({
-      config,
-      appName,
-      version,
-      latestCommitHash,
-      latestCommitUrl,
-    });
-  });
+  await runStep(
+    {
+      title: 'Notifying releaseStart to Slack',
+      skipIf: () =>
+        !config.slackIncomingHook ||
+        !config.slack ||
+        !config.slack.releaseStart,
+    },
+    async () => {
+      await notifyReleaseStart({
+        config,
+        appName,
+        version,
+        latestCommitHash,
+        latestCommitUrl,
+      });
+    }
+  );
diff --git a/packages/shipjs/src/step/release/notifyReleaseSuccess.js b/packages/shipjs/src/step/release/notifyReleaseSuccess.js
@@ -9,13 +9,22 @@ export default async ({
   latestCommitUrl,
   repoURL,
 }) =>
-  await runStep({ title: 'Notifying releaseSuccess to Slack' }, async () => {
-    await notifyReleaseSuccess({
-      config,
-      appName,
-      version,
-      latestCommitHash,
-      latestCommitUrl,
-      repoURL,
-    });
-  });
+  await runStep(
+    {
+      title: 'Notifying releaseSuccess to Slack',
+      skipIf: () =>
+        !config.slackIncomingHook ||
+        !config.slack ||
+        !config.slack.releaseSuccess,
+    },
+    async () => {
+      await notifyReleaseSuccess({
+        config,
+        appName,
+        version,
+        latestCommitHash,
+        latestCommitUrl,
+        repoURL,
+      });
+    }
+  );