-
Notifications
You must be signed in to change notification settings - Fork 385
Conversation
Deploy preview for react-instantsearch ready! Built with commit 28d4380 https://deploy-preview-2922--react-instantsearch.netlify.app |
There was one part that caused many failing tests. |
… upath in react-scripts were outdated
e7b9ec1
to
4d9df65
Compare
I didn't manage to run Plus, I've replaced deprecated This will close #2908 |
The only remaining part in this PR is to make Does someone, probably @yannickcr, know if there's any special config to run this locally on
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven’t tried the rn example yet
@@ -23,7 +23,7 @@ aliases: | |||
defaults: &defaults | |||
working_directory: ~/react-instantsearch | |||
docker: | |||
- image: circleci/node:8.16.1@sha256:9e83d4b3b046d1c7591952865bc4d803d2ddeaf1c6352f76c2133bbe96606d40 | |||
- image: circleci/node:12.14.1@sha256:bc28f8653824cc4e28902e73d140011c94dfeda8b1f83393d049daa468f51693 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This no longer has -browsers. Expected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my trials, only the integration test requires -browser
image.
const isFirstWidgetIndex = isIndexWidget(firstWidget); | ||
const isSecondWidgetIndex = isIndexWidget(secondWidget); | ||
|
||
if (isFirstWidgetIndex && !isSecondWidgetIndex) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you need to make these changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding that function, lots of tests failed. I searched for it and there has been a change in the implementation of Array.sort() in Node v11 (link).
And the previous implementation of sortIndexWidgetsFirst
didn't consider the both widgets being index. After fixing them like this, all the tests passed.
Co-authored-by: Yannick Croissant <[email protected]>
Summary
examples/react-native
andexamples/react-native-query-suggestions
has been re-written. I couldn't update their dependencies correctly to make them work. So I created new projects from scratch by usingexpo
, and I copied&pasted the same code we had there.The only part I changed in the examples is, replacing
ListView
toFlatList
.ListView
is deprecated, so I had to do that.Except for the examples, there isn't much. Let me know if something isn't clear.
And let me know if you wish me to tidyng up this PR by creating stacked PRs for those examples.