Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate to a monorepo #5162

Merged
merged 53 commits into from
Nov 22, 2022
Merged

refactor: migrate to a monorepo #5162

merged 53 commits into from
Nov 22, 2022

Conversation

Haroenv
Copy link
Contributor

@Haroenv Haroenv commented Nov 16, 2022

This PR is obviously very big, but it doesn't work on its own unfortunately, everything needs to be moved for it to work.

  1. a monorepo is set up with Lerna (latest version, so using nx)
  2. source code of instantsearch.js is moved into its own package (same readme on both levels for now)
  3. scripts are either kept in the same place, moved into instantsearch folder
  4. mocks and testutils that will be useful for other packages later are moved into its own packages
  5. examples are made part of the workspace, got updated dependencies and use the local instantsearch.js
  6. examples are moved in a subfolder (in src and website) and have a redirect set up
  7. ci has been rewritten to be able to use cache and workspace
  8. modify the "algoliasearch v3" test to deal with multiple dependencies

This depends on two pull requests that can be merged or released either before or after this PR:

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 16, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f0e464f:

Sandbox Source
InstantSearch.js Configuration

@Haroenv Haroenv changed the title Feat/monorepo refactor: migrate to a monorepo Nov 18, 2022
@Haroenv Haroenv marked this pull request as ready for review November 18, 2022 17:00
babel.config.js Outdated Show resolved Hide resolved
Copy link
Member

@sarahdayan sarahdayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on our peer review yesterday, LGTM 👍

Fantastic work ✨

@Haroenv Haroenv merged commit 644f456 into master Nov 22, 2022
@Haroenv Haroenv deleted the feat/monorepo branch November 22, 2022 15:28
Haroenv added a commit that referenced this pull request Dec 6, 2022
When refactoring this in #5162 this part wasn't run, so it didn't error on CI
Haroenv added a commit that referenced this pull request Dec 6, 2022
When refactoring this in #5162 this part wasn't run, so it didn't error on CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants