Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ts): convert hierarchical-menu to TypeScript #4711

Merged
merged 18 commits into from
Apr 8, 2021

Conversation

yannickcr
Copy link
Contributor

Summary

Converts the hierarchical-menu to TypeScript

@yannickcr yannickcr requested review from a team, eunjae-lee and tkrugg and removed request for a team April 1, 2021 13:11
@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 1, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f81753d:

Sandbox Source
InstantSearch.js Configuration

Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall pretty good, just some stuff that used to be wrong already that I noticed now :)

@yannickcr yannickcr force-pushed the feat/ts-hierarchicalmenu branch from 1621d9f to 9138e69 Compare April 1, 2021 16:08
@yannickcr yannickcr requested a review from Haroenv April 1, 2021 16:13
Base automatically changed from feat/ts-refinementlist to master April 6, 2021 13:49
Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks again for this @yannickcr

@Haroenv Haroenv requested a review from shortcuts April 7, 2021 13:53
Copy link
Contributor

@eunjae-lee eunjae-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Haroenv Haroenv merged commit 870e2f7 into master Apr 8, 2021
@Haroenv Haroenv deleted the feat/ts-hierarchicalmenu branch April 8, 2021 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants