-
Notifications
You must be signed in to change notification settings - Fork 3
feat(spec): add spec for initializing the state from the route #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we adding another test suite for writing in the router or should we address these cases in here?
What do you mean by writing in the router? Making changes in the refinements and check if they are correctly passed in the URL? |
That's how I interpret it as well @yannickcr, making some changes, and checking if the URL is correct |
Ok, in that case I think it can be added to this test. |
We only test one part of the routing here. We're checking that:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
Add a spec for initializing the state from the route.
Will test the following scenario: