This repository has been archived by the owner on Jan 4, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs(contributing): add CONTRIBUTING.md file #1
docs(contributing): add CONTRIBUTING.md file #1
Changes from all commits
64ee816
19bf1c8
e1ef3c4
44db89b
1b8c335
c2e3d4c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is using await really necessary in our case? Since we're using the bakedin test runner await is implicit:
https://webdriver.io/docs/setuptypes.html#the-wdio-testrunner
It can still be something we want to enforce anyway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'm not sure their documentation is correct since all the commands still returns Promises and I had some issues when not using
await
😐.But it will be enforced by the
@typescript-eslint/no-floating-promises
ESLint rule so we should not have any problem with this.