Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(autocompleteOptions): allow cssClasses options #246

Merged
merged 1 commit into from
Nov 27, 2017
Merged

fix(autocompleteOptions): allow cssClasses options #246

merged 1 commit into from
Nov 27, 2017

Conversation

davidohlin
Copy link
Contributor

Let through options passed in autocompleteOptions.cssClasses and use prefix: 'ds' as default.

Right now, options being are overwritten on these lines.

Have a good weekend! ☀️

Haroenv
Haroenv reviewed Nov 25, 2017
View reviewed changes
Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks okay to me!

@Haroenv Haroenv requested a review from vvo November 25, 2017 00:06
@Haroenv
Copy link
Contributor

Haroenv commented Nov 25, 2017

Thanks for your contribution!

@vvo
Copy link
Contributor

vvo commented Nov 27, 2017

All good

@vvo vvo merged commit 6de70c3 into algolia:master Nov 27, 2017
maxiloc added a commit that referenced this pull request Nov 28, 2017
@maxiloc
v2.5.0
23d7a52 
<a name="2.5.0"></a>
# [2.5.0](v2.4.1...v2.5.0) (2017-11-28)

### Bug Fixes

* **autocompleteOptions:** allow cssClasses options ([#246](#246)) ([6de70c3](6de70c3))

### Features

* **global:** Add responsive feature to the dropdown ([777d2d4](777d2d4))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Haroenv Haroenv Haroenv left review comments

@vvo vvo Awaiting requested review from vvo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidohlin @Haroenv @vvo