Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v3): require appId #1299

Merged
merged 3 commits into from
Feb 21, 2022
Merged

feat(v3): require appId #1299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6613ad6
feat(v3): require appId
shortcuts Feb 9, 2022
0db9466
Merge branch 'next' into feat/require-appId
shortcuts Feb 18, 2022
d1aaded
Merge branch 'next' into feat/require-appId
shortcuts Feb 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/docsearch-react/src/DocSearch.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export type DocSearchTranslations = Partial<{
}>;

export interface DocSearchProps {
appId?: string;
appId: string;
apiKey: string;
indexName: string;
placeholder?: string;
Expand Down
2 changes: 1 addition & 1 deletion packages/docsearch-react/src/DocSearchModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export type DocSearchModalProps = DocSearchProps & {
};

export function DocSearchModal({
appId = 'BH4D9OD16A',
appId,
apiKey,
indexName,
placeholder = 'Search docs',
Expand Down
4 changes: 3 additions & 1 deletion packages/docsearch-react/src/__tests__/api.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@ import { DocSearch as DocSearchComponent } from '../DocSearch';
import type { DocSearchProps } from '../DocSearch';

function DocSearch(props: Partial<DocSearchProps>) {
return <DocSearchComponent apiKey="foo" indexName="bar" {...props} />;
return (
<DocSearchComponent appId="woo" apiKey="foo" indexName="bar" {...props} />
);
}

// mock empty response
Expand Down