Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): make react an optional peer dependency in @docsearch/react #1273

Merged
merged 5 commits into from
Aug 15, 2022
Merged

fix(deps): make react an optional peer dependency in @docsearch/react #1273

merged 5 commits into from
Aug 15, 2022

Conversation

brc-dd
Copy link
Contributor

@brc-dd brc-dd commented Jan 16, 2022 •
edited
Loading

fixes (partially) #1272

@netlify
Copy link

netlify bot commented Jan 16, 2022 •
edited
Loading

✅ Deploy Preview for docsearch canceled.

Name Link
🔨 Latest commit 06363c7
🔍 Latest deploy log https://app.netlify.com/sites/docsearch/deploys/62fac1d57bbb550008bd0a33

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 16, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e1ad16d:

Sandbox Source
Vanilla Configuration

@brc-dd brc-dd mentioned this pull request Jun 1, 2022
Open
@brc-dd
Copy link
Contributor Author

brc-dd commented Jun 3, 2022

Hi @shortcuts! Sorry for pinging you directly. But can this be looked into?

@benmccann
Copy link

@brc-dd it looks like this PR needs to be rebased

@shortcuts would you be able to review this PR? It's a major stumbling block to using Algolia with non-React projects like Vue, Svelte, etc. Are there any concerns you have or things we could help test?

shortcuts
shortcuts reviewed Aug 14, 2022
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I'm fine with the workaround if we can't apply it at the JS package level

packages/docsearch-react/package.json Show resolved Hide resolved
shortcuts
shortcuts approved these changes Aug 15, 2022
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and investigation!

@shortcuts shortcuts changed the title fix: make react an optional peer dependency in @docsearch/react fix(deps): make react an optional peer dependency in @docsearch/react Aug 15, 2022
@shortcuts shortcuts merged commit eb44d0c into algolia:main Aug 15, 2022
@brc-dd brc-dd deleted the patch-1 branch August 15, 2022 23:49
@benmccann
Copy link

Thanks for the merge! Any chance we can get a new release?

@shortcuts
Copy link
Member

Thanks for the merge! Any chance we can get a new release?

Hey, it's released in 3.2.1!

@SimenB
Copy link

SimenB commented Aug 16, 2022

@shortcuts are you sure? 😅

https://www.npmjs.com/package/@docsearch/react
image

@shortcuts
Copy link
Member

@shortcuts are you sure? 😅

https://www.npmjs.com/package/@docsearch/react

image

Oops, now it's good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shortcuts shortcuts shortcuts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brc-dd @benmccann @shortcuts @SimenB