Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Judging the iScomposing property when searchbox input #1043

Open
mantou132 opened this issue Sep 4, 2021 · 3 comments · Fixed by algolia/autocomplete#1226 or algolia/autocomplete#1238
Open

Judging the iScomposing property when searchbox input #1043

mantou132 opened this issue Sep 4, 2021 · 3 comments · Fixed by algolia/autocomplete#1226 or algolia/autocomplete#1238

Comments

@mantou132
Copy link

mantou132 commented Sep 4, 2021 •
edited
Loading

Describe the problem

When you haven't selected it in the input method, you should not request a request.

Describe the solution

Use https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/isComposing
@Haroenv
Copy link
Contributor

Haroenv commented Sep 6, 2021

Do you have a suggestion where this would be used in the code base?

@mantou132
Copy link
Author

see issue: #1304

Haroenv added a commit to algolia/autocomplete that referenced this issue Feb 21, 2022
@Haroenv
fix(composition): do not submit when user is composing
685547f 
"composing" is used on Japanese (and other CJK scripts) when typing on a qwerty or similar keyboard, showing something akin to autocomplete on iOS. You confirm a word by pressing enter, which shouldn't commit to a search.

Still needs to be tested thoroughly, as it's possible we need to check isComposing earlier to prevent searching for the intermediate romanji characters.

Fixes algolia/docsearch#1304
Fixes algolia/docsearch#1043
@Haroenv Haroenv mentioned this issue Feb 21, 2022
Closed
@Haroenv Haroenv mentioned this issue Dec 14, 2023
Merged
@dhayab dhayab mentioned this issue Jan 25, 2024
Merged
@dhayab
Copy link
Member

dhayab commented Jan 30, 2024

Reopening this issue to let the docsearch team handle updating autocomplete and forwarding ignoreCompositionEvents.

@dhayab dhayab reopened this Jan 30, 2024
@tats-u tats-u mentioned this issue Mar 25, 2024
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@dhayab @mantou132 @Haroenv