fix(core): support Insights in requesters #562
Merged
+151
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description In #540, we introduced the Requester API to batch Algolia queries, but we [left out Insights plugin support](https://github.com/algolia/autocomplete/blob/c62f1d2757c5824c5a2f456c20cf55ca3d962cdb/packages/autocomplete-preset-algolia/src/search/getAlgoliaHits.ts#L18-L19). These metadata fields are required for the Insights plugin to send events to the API. This PR brings support for the Insights plugin from requesters by adding back the necessary metadata in the hits returned by the Algolia API. ## Related - #559 (reply in thread)
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 888e01e:
|
sarahdayan
approved these changes
May 3, 2021
Haroenv
reviewed
May 3, 2021
| > = rawResults.map((result) => { | ||
| return { | ||
| ...result, | ||
| hits: (result as SearchResponse<THit>).hits?.map((hit) => { |
There was a problem hiding this comment.
I don't see a check for sffv response here, are you relying on it being undefined?
There was a problem hiding this comment.
Yes—we don't transform hits if it's not defined.
We don't support Insights for facet hits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #540, we introduced the Requester API to batch Algolia queries, but we left out Insights plugin support. These metadata fields are required for the Insights plugin to send events to the API.
This PR brings support for the Insights plugin from requesters by adding back the necessary metadata in the hits returned by the Algolia API.
Related