-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): open closed panel on ArrowDown
and ArrowUp
#599
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit bc45547:
|
Putting "On Hold" because tests are not failing when they should (they're not run correctly). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one!
Summary
With the input focused, pressing ↓ or ↑ should open the panel if it was previously closed.
Result
With
openOnFocus: true
or a query, and the input focused:Reference: w3c aria practices
Closes #584