suggestions

algolia · Feb 9, 2023 · d5f8fc3 · d5f8fc3
1 parent d1e09d3
commit d5f8fc3
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/packages/autocomplete-core/src/types/AutocompleteSource.ts b/packages/autocomplete-core/src/types/AutocompleteSource.ts
@@ -44,7 +44,12 @@ export type OnResolveParams<TItem extends BaseItem> = {
   state: AutocompleteState<TItem>;
 };
 
-type DefaultIndicator = { __default?: boolean };
+type DefaultIndicator = {
+  /**
+   * Optional key on a function to indicate it's the default value of this function.
+   */
+  __default?: boolean;
+};
 
 export interface AutocompleteSource<TItem extends BaseItem> {
   /**

diff --git a/packages/autocomplete-plugin-redirect-url/src/createRedirectUrlPlugin.ts b/packages/autocomplete-plugin-redirect-url/src/createRedirectUrlPlugin.ts
@@ -119,7 +119,9 @@ export function createRedirectUrlPlugin<TItem extends BaseItem>(
               if (source.getItemInputValue!.__default) {
                 warn(
                   false,
-                  `The source ${source.sourceId} does not have a \`getItemInputValue\` function. It's required to be able to filter out the redirect item.` +
+                  `The source ${JSON.stringify(
+                    source.sourceId
+                  )} does not have a \`getItemInputValue\` function. It's required to be able to filter out the redirect item.` +
                     '\nSee https://www.algolia.com/doc/ui-libraries/autocomplete/core-concepts/sources/#param-getiteminputvalue'
                 );
                 return true;
@@ -133,7 +135,9 @@ export function createRedirectUrlPlugin<TItem extends BaseItem>(
               if (itemInputValue === undefined) {
                 warn(
                   false,
-                  `The source ${source.sourceId} does not return a string from the \`getItemInputValue\` function. It's required to be able to filter out the redirect item.` +
+                  `The source ${JSON.stringify(
+                    source.sourceId
+                  )} does not return a string from the \`getItemInputValue\` function. It's required to be able to filter out the redirect item.` +
                     '\nSee https://www.algolia.com/doc/ui-libraries/autocomplete/core-concepts/sources/#param-getiteminputvalue'
                 );
                 return true;