fix(enterKeyHint): samsung browser should be detected as chrome (#933)

* fix(enterKeyHint): samsung browser should be detected as chrome * remove isChrome util
algolia · Apr 5, 2022 · 93a1fc2 · 93a1fc2
1 parent c08189d
commit 93a1fc2
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 220 deletions.
diff --git a/packages/autocomplete-core/src/getPropGetters.ts b/packages/autocomplete-core/src/getPropGetters.ts
@@ -14,7 +14,7 @@ import {
   GetRootProps,
   InternalAutocompleteOptions,
 } from './types';
-import { getActiveItem, isChrome, isOrContainsNode, isSamsung } from './utils';
+import { getActiveItem, isOrContainsNode, isSamsung } from './utils';
 
 interface GetPropGettersOptions<TItem extends BaseItem>
   extends AutocompleteScopeApi<TItem> {
@@ -163,7 +163,7 @@ export function getPropGetters<
     const activeItem = getActiveItem(store.getState());
 
     const userAgent = props.environment.navigator?.userAgent;
-    const shouldFallbackKeyHint = isSamsung(userAgent) && isChrome(userAgent);
+    const shouldFallbackKeyHint = isSamsung(userAgent);
     const enterKeyHint =
       activeItem?.itemUrl && !shouldFallbackKeyHint ? 'go' : 'search';
 

diff --git a/packages/autocomplete-core/src/utils/__tests__/isChrome.test.ts b/packages/autocomplete-core/src/utils/__tests__/isChrome.test.ts
diff --git a/packages/autocomplete-core/src/utils/index.ts b/packages/autocomplete-core/src/utils/index.ts
@@ -3,7 +3,6 @@ export * from './createCancelablePromiseList';
 export * from './createConcurrentSafePromise';
 export * from './getNextActiveItemId';
 export * from './getNormalizedSources';
-export * from './isChrome';
 export * from './getActiveItem';
 export * from './isOrContainsNode';
 export * from './isSamsung';

diff --git a/packages/autocomplete-core/src/utils/isChrome.ts b/packages/autocomplete-core/src/utils/isChrome.ts